chore: minor change in bin/apisix #2847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@willmafh Your commit message is not "semantic", so the CI failed, please modify it and highlights the code changes :). |
membphis
approved these changes
Nov 25, 2020
spacewander
approved these changes
Nov 25, 2020
Contributor
Author
|
@tokers I don't get it...I've already read the CONTRIBUTING.md guideline and everything seems OK... |
Contributor
Member
|
It would be better if we add the semantic check detail to CONTRIBUTING.md. |
Member
Welcome to create a new issue about this, then the community can contribute this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
openresty -v 2>&1twice to get correct version.