-
Notifications
You must be signed in to change notification settings - Fork 2.8k
WIP - feat(CI): switch to using the GitHub Super-Linter #3045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI failed. @juzhiyuan is github actions limited? |
I don't think so, it's failed due to lint errors 🤔 |
|
@jbampton has not finished yet, as the "WIP" indicated. We need to be patient. |
|
@jbampton you need to rebase your branch |
20b6404 to
f1db4ae
Compare
9ce308c to
d450ad9
Compare
|
Pinging @spacewander Do we have to set this in the repo settings? From the site: "NOTE: If you pass the Environment variable GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} in your workflow, then the GitHub Super-Linter will mark the status of each individual linter run in the Checks section of a pull request. Without this you will only see the overall status of the full run. There is no need to set the GitHub Secret as it is automatically set by GitHub, it only needs to be passed to the action." |
|
If |
|
It looks like it is using the By using the We seem to have some errors and maybe this is related seen in the image below: Seen in the last run -> https://github.com/apache/apisix/pull/3045/checks?check_run_id=1686557482 |
2f82333 to
4f767f5
Compare
cc99e71 to
b47d990
Compare
f874f0c to
6aaaf26
Compare
https://github.com/marketplace/actions/super-linter Running checks ERROR_ON_MISSING_EXEC_BIT: true VALIDATE_BASH: true VALIDATE_BASH_EXEC: true VALIDATE_EDITORCONFIG: true VALIDATE_GO: true VALIDATE_JAVA: true VALIDATE_JSON: true VALIDATE_LUA: true VALIDATE_MARKDOWN: true VALIDATE_PERL: true VALIDATE_PYTHON: false VALIDATE_PYTHON_BLACK: true VALIDATE_PYTHON_FLAKE8: true VALIDATE_PYTHON_ISORT: true VALIDATE_PYTHON_MYPY: true VALIDATE_PYTHON_PYLINT: true VALIDATE_SHELL_SHFMT: true VALIDATE_XML: true VALIDATE_YAML: true


https://github.com/marketplace/actions/super-linter
Running checks
What this PR does / why we need it:
Lints and standardizes the codebase.
Pre-submission checklist: