Skip to content

feat: validate certificate & key #3085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spacewander merged 1 commit into from
Dec 23, 2020
Merged

feat: validate certificate & key #3085

spacewander merged 1 commit into from
Dec 23, 2020

Conversation

@spacewander
Copy link
Member

@spacewander spacewander commented Dec 21, 2020

Fix #296
Fix #2816

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
feat: validate certificate & key
2538a16 
Fix apache#296
Fix apache#2816

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander merged commit 966d688 into apache:master Dec 23, 2020
@spacewander spacewander mentioned this pull request Dec 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@membphis membphis membphis approved these changes

@tokers tokers tokers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[DISCUSS]: APISIX should check the ssl certificate in "apisix/admin/ssl" API feature(https): verify request key when creating an SSL object.

3 participants

@spacewander @membphis @tokers