fix: validate plugins configuration of plugin_config via incremental sync
#3700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
approved these changes
Feb 28, 2021
tokers
requested changes
Mar 1, 2021
| === TEST 2: validated plugins configuration via incremental sync |
Contributor
There was a problem hiding this comment.
You may add some test cases that written some malformed data to etcd and detect the error log in APISIX.
tokers
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
close #3674
Currently, the
item_schemais not set forplugin_config,which causes the plugin configuration to not be validated when incrementally updated from ETCD (see: https://github.com/apache/apisix/blob/master/apisix/core/config_etcd.lua#L347),
resulting in the default value of the plugin configuration not being set.
Pre-submission checklist: