Skip to content

Conversation

@dickens7
Copy link
Contributor

@dickens7 dickens7 commented May 11, 2021

#4209

This PR is a draft version, used to discuss implementation

@dickens7 dickens7 changed the title feat snowflake plugin [WIP] feat snowflake plugin May 11, 2021
@moonming
Copy link
Member

I am not sure that do we should add a plugin for request id?

@Yiyiyimu
Copy link
Member

I am not sure that do we should add a plugin for request id?

Agreed. Since it's an alternative algorithm for request-id, it might be better to add an enum argument to request-id, instead of using it as another plugin

@dickens7
Copy link
Contributor Author

I am not sure that do we should add a plugin for request id?

Agreed. Since it's an alternative algorithm for request-id, it might be better to add an enum argument to request-id, instead of using it as another plugin

It is planned like this. Now we are solving the problem that the snowflake algorithm can only have 1024 workers

@Yiyiyimu
Copy link
Member

It is planned like this. Now we are solving the problem that the snowflake algorithm can only have 1024 workers

Do you mind sharing the reason for "planned like this"

@dickens7
Copy link
Contributor Author

dickens7 commented Jul 7, 2021

Refactor

@dickens7 dickens7 closed this Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants