docs(FAQ): add a note in "How to allow all IPs to access Admin API" #4264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
May 18, 2021
docs/en/latest/FAQ.md
Outdated
|
|
||
| Restart or reload APISIX, all IPs can access the `Admin API`. | ||
|
|
||
| >Note: You can use this method in the exercise to allow all IPs to access your `Apache APISIX` instance, but it is not safe to use it in a production environment. In production, please only authorize specific IP addresses or address ranges to access your instance. |
Member
There was a problem hiding this comment.
Better to use **...** for Note.
spacewander
approved these changes
May 18, 2021
starsz
reviewed
May 18, 2021
docs/zh/latest/FAQ.md
Outdated
|
|
||
| 重启或 reload APISIX，所有 IP 便可以访问 `Admin API`。 | ||
|
|
||
| **注意：您可以在练习中使用此方法，以允许所有 IP 访问您的 `Apache APISIX` 实例，但是在生产环境中使用它并不安全。在生产中，请仅授权特定的 IP 地址或地址范围访问您的实例。** |
tokers
reviewed
May 19, 2021
docs/en/latest/FAQ.md
Outdated
|
|
||
| Restart or reload APISIX, all IPs can access the `Admin API`. | ||
|
|
||
| **Note: You can use this method in a non-production environment to allow all IPs to access your `Apache APISIX` instance, but it is not safe to use it in a production environment. In production, please only authorize specific IP addresses or address ranges to access your instance.** |
Contributor
There was a problem hiding this comment.
Suggested change
| **Note: You can use this method in a non-production environment to allow all IPs to access your `Apache APISIX` instance, but it is not safe to use it in a production environment. In production, please only authorize specific IP addresses or address ranges to access your instance.** | |
| **Note: You can use this method in a non-production environment to allow all clients from anywhere to access your `Apache APISIX` instances, but it is not safe to use it in a production environment. In production, please only authorize specific IP addresses or address ranges to access your instance.** |
tokers
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Signed-off-by: Firstsawyou yuelinz99@gmail.com
Add a warning note in the
How to allow all IPs to access the Admin APIsection of the FAQ.Pre-submission checklist: