feat: add real_ip_recursive to nginx.conf #4332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstsawyou
reviewed
May 28, 2021
Contributor
Firstsawyou
left a comment
Firstsawyou
left a comment
There was a problem hiding this comment.
We should add corresponding test cases. https://github.com/apache/apisix/blob/master/t/cli/test_main.sh
spacewander
reviewed
May 28, 2021
spacewander
reviewed
May 28, 2021
starsz
approved these changes
May 28, 2021
Contributor
starsz
left a comment
starsz
left a comment
There was a problem hiding this comment.
LGTM.Need to fix the conflict.
tokers
approved these changes
May 29, 2021
spacewander
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enable to set real_ip_recursive to nginx.conf. When apisix is behind multiple layer network, the real client ip may not be recognized. See also http://nginx.org/en/docs/http/ngx_http_realip_module.html#real_ip_recursive
Pre-submission checklist: