fix: add error handling when use customized config #4342
Merged
spacewander merged 5 commits intoapache:masterfrom Jun 1, 2021
Merged
fix: add error handling when use customized config #4342spacewander merged 5 commits intoapache:masterfrom
spacewander merged 5 commits intoapache:masterfrom
Conversation
spacewander
reviewed
May 31, 2021
spacewander
approved these changes
May 31, 2021
tokers
approved these changes
May 31, 2021
starsz
approved these changes
May 31, 2021
Member
Author
|
@spacewander PTAL |
spacewander
approved these changes
Jun 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yiyiyimu wosoyoung@gmail.com
What this PR does / why we need it:
Ref: #4337
When implementing with #2101, no error handling is implemented so with the invalid config file, apisix would still start without the correct config setup. Here to fix it.
One thing to mention, since I failed to figure out how to get stderr separately when running shell command in Lua, considering normally stdout of
lsandmvwould always be empty (on ubuntu), I forward stderr to stdout to get the error msg and fail fast. Not sure if it's working in all OS.Pre-submission checklist: