chore: using util lib to exectue cmd #4406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
requested changes
Jun 10, 2021
|
|
||
|
|
||
| function _M.try_read_attr(tab, ...) | ||
| local count = select('#', ...) |
Member
There was a problem hiding this comment.
Changes below are quite trivial. We don't accept such change which breaks the git blame.
Please remove them.
| local lsof_cmd = "lsof -p " .. pid | ||
| local hd = popen(lsof_cmd) | ||
| local res = hd:read("*a") | ||
| local res, err = util.execute_cmd(lsof_cmd) |
Member
There was a problem hiding this comment.
We only can accept this change which refactors code and uses the common way.
Contributor
Author
|
#4406 (comment) |
mayocream
changed the title
Member
|
Need to fix the lint |
Contributor
Author
|
Fixed. |
spacewander
approved these changes
Jun 15, 2021
tokers
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I was reading APISIX code, and found some code could be simplified or reformat.
This PR didn't solve any problems though.
Pre-submission checklist:
None.
No addition features.
No docs related.