Skip to content

chore: print error in CLI when json decode failed #4518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tokers merged 1 commit into from
Jul 2, 2021
Merged

chore: print error in CLI when json decode failed #4518

tokers merged 1 commit into from
Jul 2, 2021

Conversation

@Yiyiyimu
Copy link
Member

@Yiyiyimu Yiyiyimu commented Jul 1, 2021

Signed-off-by: yiyiyimu wosoyoung@gmail.com

What this PR does / why we need it:

Since it's part of the CLI, better print error on CLI compared to just in log

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@Yiyiyimu
chore: also print error when json decode failed
37449ef 
Signed-off-by: yiyiyimu <wosoyoung@gmail.com>
@tokers tokers merged commit e35ef6d into apache:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacewander spacewander spacewander approved these changes

@tokers tokers tokers approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yiyiyimu @spacewander @tokers