Skip to content

Conversation

@ramessesii2
Copy link

@ramessesii2 ramessesii2 commented Sep 5, 2021

Fix #4981
previously "discovery_type" only showed support for "eureka", now added "consul_kv", "eureka", "dns", "nacos".

tmep

previously "discovery_type" only showed support for "eureka", now added "consul_kv", "eureka", "dns", "nacos".
|nodes |required, can't be used with `service_name` |Hash table or array. If it is a hash table, the key of the internal element is the upstream machine address list, the format is `Address + (optional) Port`, where the address part can be IP or domain name, such as `192.168.1.100:80`, `foo.com:80`, etc. The value is the weight of node. If it is an array, each item is a hash table with key `host`/`weight` and optional `port`/`priority`. The `nodes` can be empty, which means it is a placeholder and will be filled later. Clients use such an upstream will get 502 response. |`192.168.1.100:80`|
|service_name |required, can't be used with `nodes` |the name of service used in the service discovery, see [discovery](discovery.md) for more details|`a-bootiful-client`|
|discovery_type |required, if `service_name` is used | the type of service discovery, see [discovery](discovery.md) for more details|`eureka`|
|discovery_type |required, if `service_name` is used | the type of service discovery, see [discovery](discovery.md) for more details|`consul_kv`, `eureka`, `dns`, `nacos`|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cell is just an example. You need to add the types after "the type of service discovery, see discovery for more details".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cell is just an example. You need to add the types after "the type of service discovery, see discovery for more details".

ok, my bad.

@spacewander spacewander changed the title Corrected documentation,"discovery_type" docs: fulfill discovery_type description Sep 5, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: need to update the doc about discovery_type of upstream

2 participants