Skip to content

chore: avoid defining read_file repeatedly #5062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spacewander merged 1 commit into from
Sep 15, 2021
Merged

chore: avoid defining read_file repeatedly #5062

spacewander merged 1 commit into from
Sep 15, 2021

Conversation

@spacewander
Copy link
Member

@spacewander spacewander commented Sep 14, 2021

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
chore: avoid defining read_file repeatedly
4ca1ece 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander merged commit 11763b8 into apache:master Sep 15, 2021
@spacewander spacewander deleted the rfpr branch September 15, 2021 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tokers tokers tokers approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

@nic-chen nic-chen nic-chen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spacewander @tokers @tzssangglass @nic-chen