feat: add ulimit too small prompt #5078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rao yunkun <yunkunrao@gmail.com>
tokers
reviewed
Sep 16, 2021
apisix/cli/ops.lua
Outdated
| end | ||
|
|
||
| if env.ulimit <= 1024 then | ||
| print(str_format("Warning! Current user limits [%d] too small, please modify user limits by execute \'ulimt -n <new user limits>\' , otherwise the performance is low.", env.ulimit)) |
Contributor
There was a problem hiding this comment.
Suggested change
| print(str_format("Warning! Current user limits [%d] too small, please modify user limits by execute \'ulimt -n <new user limits>\' , otherwise the performance is low.", env.ulimit)) | |
| print(str_format("Warning! Current user limits [%d] is too small, please modify user limits by execute \'ulimt -n <new user limits>\' , otherwise the performance is low.", env.ulimit)) |
spacewander
reviewed
Sep 17, 2021
apisix/cli/env.lua
Outdated
|
|
||
| return function (apisix_home, pkg_cpath_org, pkg_path_org) | ||
| -- ulimit setting should be checked when APISIX starts | ||
| ulimit = tonumber(util.trim(util.execute_cmd("ulimit -n"))) |
Member
There was a problem hiding this comment.
Should check the nil, err returned from execute_cmd, and log the err
apisix/cli/ops.lua
Outdated
| end | ||
|
|
||
| if env.ulimit <= 1024 then | ||
| print(str_format("Warning! Current user limits [%d] is too small, please modify user limits by execute \'ulimt -n <new user limits>\' , otherwise the performance is low.", env.ulimit)) |
Member
There was a problem hiding this comment.
Better to mention what kind of the limit
spacewander
changed the title
Signed-off-by: rao yunkun <yunkunrao@gmail.com>
spacewander
reviewed
Sep 18, 2021
Member
spacewander
left a comment
spacewander
left a comment
There was a problem hiding this comment.
Need to fix the lint: https://github.com/apache/apisix/runs/3638128084
Signed-off-by: rao yunkun <yunkunrao@gmail.com>
Signed-off-by: rao yunkun <yunkunrao@gmail.com>
spacewander
approved these changes
Sep 19, 2021
nic-chen
approved these changes
Sep 20, 2021
Member
nic-chen
left a comment
nic-chen
left a comment
There was a problem hiding this comment.
should be better add a test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rao yunkun yunkunrao@gmail.com
What this PR does / why we need it:
This PR is related with #2467
Pre-submission checklist: