Skip to content

Conversation

@qizhendong1
Copy link
Contributor

@qizhendong1 qizhendong1 commented Sep 28, 2021

fix #5146

use ngx.update_time() function to update cache time

Signed-off-by: qizhendong qizhendong@cmss.china.mobile.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Copy link
Member

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution is incorrect, see my comments:
#5146 (comment)
#5146 (comment)
#5146 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Prometheus plugin metrics http latency sum is negative

2 participants