-
Notifications
You must be signed in to change notification settings - Fork 2.8k
test: grpc stream proxy test with test nginx #5319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: grpc stream proxy test with test nginx #5319
Conversation
Co-authored-by: leslie <59061168+leslie-tsang@users.noreply.github.com>
…ix into grpc_stream_proxy_test
ci/linux_openresty_common_runner.sh
Outdated
| # sleep 1 | ||
|
|
||
| ./bin/apisix stop | ||
| sleep 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove this whole segment, not required anymore (Line 71 - Line 111). WDYT @spacewander?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Remember to put this back:
# ensure grpc server example is already started
for (( i = 0; i <= 100; i++ )); do
if [[ "$i" -eq 100 ]]; then
echo "failed to start grpc_server_example in time"
exit 1
fi
nc -zv 127.0.0.1 50051 && break
sleep 1
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks for pointing it out.
| git clone https://github.com/iresty/grpc_server_example.git grpc_server_example | ||
| cd grpc_server_example/ && mv proto/ ../build-cache/ && cd .. | ||
| ./build-cache/grpc_server_example \ | ||
| cd build-cache/ && wget https://golang.org/dl/go1.15.linux-amd64.tar.gz && tar -xf go1.15.linux-amd64.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to put a comment here to show why we need to download Go manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack.
| # install and start grpc_server_example | ||
| cd t/grpc_server_example | ||
|
|
||
| if [ ! "$(ls -A . )" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to add a comment about why this branch is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
ci/linux_openresty_common_runner.sh
Outdated
| # sleep 1 | ||
|
|
||
| ./bin/apisix stop | ||
| sleep 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Remember to put this back:
# ensure grpc server example is already started
for (( i = 0; i <= 100; i++ )); do
if [[ "$i" -eq 100 ]]; then
echo "failed to start grpc_server_example in time"
exit 1
fi
nc -zv 127.0.0.1 50051 && break
sleep 1
done
724d217 to
d779f9a
Compare
What this PR does / why we need it:
As we have moved from using bash to test grpc proxy to Test NGINX #5298 (comment).
Pre-submission checklist: