ci: improve dns configures override #5601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzp2010
force-pushed
the
feat-new-set-dns
branch
from
c88d95a to
bba31ea
Compare
shuaijinchao
approved these changes
Nov 25, 2021
tzssangglass
approved these changes
Nov 25, 2021
Contributor
Author
|
ping @spacewander @membphis |
membphis
approved these changes
Nov 25, 2021
besich
pushed a commit
to besich/apisix
that referenced
this pull request
Dec 1, 2021
CentOS docker: use `--dns` parameter Ubuntu: use `netplan`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improve the script to modify DNS configuration in CI environment to adapt to
Netplan+systemd-networkd+systemd-resolveenvironment in Ubuntu. The current method of overwriting/etc/resolv.confdirectly may not work in some extreme cases.Pre-submission checklist: