Skip to content

feat(plugins): make plugins more powerfull#5821

Closed
wangxiaochuang wants to merge 1 commit intoapache:masterfrom
wangxiaochuang:patch-8
Closed

feat(plugins): make plugins more powerfull#5821
wangxiaochuang wants to merge 1 commit intoapache:masterfrom
wangxiaochuang:patch-8

Conversation

@wangxiaochuang
Copy link
Contributor

we can use ngx.req.set_uri(..., true) and some other's only rewrite phase functions

we can use ngx.req.set_uri(..., true) and some other's only rewrite phase functions
{% end %}

access_by_lua_block {
rewrite_by_lua_block {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid we'd better have a discussion about this, this change breaks the original design purposes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about this change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APISIX does not currently mount the rewrite_by_lua_block phase of openresty.

@github-actions
Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 18, 2022
@github-actions
Copy link

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants