Skip to content

docs: add offline install to 'how-to-build.md'#5829

Merged
spacewander merged 2 commits into
apache:masterfrom
123liubao:docs-add-offline-install
Dec 17, 2021
Merged

docs: add offline install to 'how-to-build.md'#5829
spacewander merged 2 commits into
apache:masterfrom
123liubao:docs-add-offline-install

Conversation

@123liubao
Copy link
Copy Markdown
Contributor

@123liubao 123liubao commented Dec 16, 2021

Signed-off-by: 123liubao chenly_61@163.com

What this PR does / why we need it:

add offline installation for how-to-build.md
resolve #5785

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Copy link
Copy Markdown
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contents LGTM, just to make sure, the ./apisix folder is created from where?

@spacewander
Copy link
Copy Markdown
Member

@leslie-tsang
Please take a look.

@123liubao
Copy link
Copy Markdown
Contributor Author

Contents LGTM, just to make sure, the ./apisix folder is created from where?

@juzhiyuan I'm not sure what do you mean , sudo mkdir -p apisix this step is to create the folder.

@leslie-tsang
Copy link
Copy Markdown
Member

Contents LGTM, just to make sure, the ./apisix folder is created from where?

folder ./apisix create by CMD sudo mkdir -p apisix, user can replace it with any other folder.

Comment on lines +62 to +65
$ sudo mkdir -p apisix
$ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm
$ sudo yum clean all && yum makecache
$ sudo yum install -y --downloadonly --downloaddir=./apisix apisix
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ sudo mkdir -p apisix
$ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm
$ sudo yum clean all && yum makecache
$ sudo yum install -y --downloadonly --downloaddir=./apisix apisix
# Create a folder `apisix` to store the RPM packages
sudo mkdir -p apisix
# Install apisix repo
sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm
# Rebuild YUM cache
sudo yum clean all && yum makecache
# Download apisix and its deps package to the `apisx` folder
sudo yum install -y --downloadonly --downloaddir=./apisix apisix

Shall we remove $ ? @juzhiyuan
IMO, $ is used to distinguish between command and its output like

$ uptime 
17:24:16 up 3 days,  8:06,  1 user,  load average: 0.00, 0.01, 0.05

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uptime is a command, right? 😄

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Comment thread docs/en/latest/how-to-build.md Outdated
Copy `./apisix` folder to the target host, run the following command to install Apache APISIX.

```shell
$ yum install ./apisix/*.rpm
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a sudo here ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK , I've already added this. Done.

Comment on lines +62 to +65
$ sudo mkdir -p apisix
$ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm
$ sudo yum clean all && yum makecache
$ sudo yum install -y --downloadonly --downloaddir=./apisix apisix
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Comment thread docs/zh/latest/how-to-build.md Outdated
拷贝 `./apisix` 文件夹到目标主机,使用以下命令安装 Apache APISIX。

```shell
$ yum install ./apisix/*.rpm
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK , I've already added this. Done.

Signed-off-by: 123liubao <chenly_61@163.com>
@juzhiyuan
Copy link
Copy Markdown
Member

Contents LGTM, just to make sure, the ./apisix folder is created from where?

@juzhiyuan I'm not sure what do you mean , sudo mkdir -p apisix this step is to create the folder.

Oh yes, I didn't notice this order 😅

image

@spacewander spacewander merged commit 07630c7 into apache:master Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request help: add offline installation for how-to-build.md

4 participants