Skip to content

fix(json): ensure empty array is the same after decode then encode #6383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spacewander merged 2 commits into from
Feb 24, 2022
Merged

fix(json): ensure empty array is the same after decode then encode #6383

spacewander merged 2 commits into from
Feb 24, 2022

Conversation

@spacewander
Copy link
Member

@spacewander spacewander commented Feb 20, 2022

Signed-off-by: spacewander spacewanderlzx@gmail.com

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@spacewander
fix(json): ensure empty array is the same after decode then encode
e2522fa 
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review February 20, 2022 12:03
tokers
tokers previously approved these changes Feb 21, 2022
View reviewed changes
lilien1010
lilien1010 previously approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@lilien1010 lilien1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@spacewander spacewander dismissed stale reviews from lilien1010 and tokers via e38e3eb February 24, 2022 03:34
@spacewander spacewander merged commit d5d1c8a into apache:master Feb 24, 2022
@spacewander spacewander deleted the jsonmea branch February 24, 2022 07:37
@tzssangglass tzssangglass mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuaijinchao shuaijinchao shuaijinchao approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

@lilien1010 lilien1010 lilien1010 left review comments

@tokers tokers tokers left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@spacewander @lilien1010 @shuaijinchao @tokers @tzssangglass