Skip to content

Conversation

@Gallardot
Copy link
Member

What this PR does / why we need it:

Fixed some curl usage errors.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

spacewander
spacewander previously approved these changes Feb 27, 2022
@spacewander spacewander requested a review from bzp2010 February 27, 2022 12:23
$ curl http://127.0.0.1:9080/headers -H 'Authorization: 123'
{
curl http://127.0.0.1:9080/headers -H 'Authorization: 123' \
-d '{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrent modification, this is the response.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I changed this to two text blocks. PTAL!

$ curl http://127.0.0.1:9080/headers -H 'Authorization: 321'
{
curl http://127.0.0.1:9080/headers -H 'Authorization: 321' \
-d '{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I changed this to two text blocks. PTAL!

@Gallardot Gallardot requested review from bzp2010 and spacewander March 1, 2022 14:58
@spacewander spacewander merged commit c37fc99 into apache:master Mar 3, 2022
@Gallardot Gallardot deleted the fix-doc branch March 24, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants