WIP feat: support customizing additional labels of metrics #6450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qizhendong1
reviewed
Feb 28, 2022
| port: 9091 | ||
| # labels: | ||
| #remote_addr: $remote_addr | ||
| #request_method: $request_method |
Contributor
There was a problem hiding this comment.
This function is useful for us. we add metrics too on our code as hard code way.
Can you list lables or give a link which labels are support on doc ?
starsz
reviewed
Mar 2, 2022
|
|
||
| ## 如何自定义附加标签 | ||
|
|
||
| 该插件支持在`conf/config`的`plugin_attr`部分自定义度量标签`Status codes`和`Latency`。亚马尔` |
leslie-tsang
requested changes
Mar 3, 2022
| ```yaml | ||
| plugin_attr: | ||
| prometheus: | ||
| prometheus: |
Member
There was a problem hiding this comment.
Suggested change
| prometheus: | |
| prometheus: |
There seems to be a mistake here.
|
|
||
| | Name | Type | Default | Description | | ||
| | ---------- | ------ | ------- | --------------------------------- | | ||
| | labels | array | | custom labels from [Nginx variables](http://nginx.org/en/docs/varindex.html) | |
Member
There was a problem hiding this comment.
Better include the references to APISIX build-in variables as well
|
|
||
| ## 如何自定义附加标签 | ||
|
|
||
| 该插件支持在`conf/config`的`plugin_attr`部分自定义度量标签`Status codes`和`Latency`。亚马尔` |
Member
There was a problem hiding this comment.
Suggested change
| 该插件支持在`conf/config`的`plugin_attr`部分自定义度量标签`Status codes`和`Latency`。亚马尔` | |
| 该插件支持在 `conf/config` 的 `plugin_attr` 部分自定义度量标签 `Status codes` 和 `Latency`。 |
|
|
||
| | 名称 | 类型 | 默认值 | 描述 | ||
| | --------- | ----- | -------- | ------------------------- | | ||
| | labels | array | | 使用 [Nginx 变量](http://nginx.org/en/docs/varindex.html)作为自定义标签 | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pre-submission checklist:
#4273