test(http-logger): fetch request and response body test case #6487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
Mar 2, 2022
t/lib/server.lua
Outdated
| end | ||
| end | ||
|
|
||
| local function str_split(str, reps) |
Member
There was a problem hiding this comment.
Let's add the mock API in the test file like:
apisix/t/plugin/clickhouse-logger.t
Line 39 in 4feab8e
It's not commonly used.
starsz
reviewed
Mar 2, 2022
| query = {query} | ||
| end | ||
| local data, err = require("cjson").decode(body) |
Contributor
There was a problem hiding this comment.
Hi, Why do we need to decode the body?
Member
Author
There was a problem hiding this comment.
The log format data is JSON, and we need to get the information in the structure.
tzssangglass
previously approved these changes
Mar 2, 2022
spacewander
reviewed
Mar 3, 2022
t/plugin/http-logger2.t
Outdated
| val = val[key] | ||
| end | ||
| end | ||
| ngx.log(ngx.ERR ,query[i], ":", val) |
Member
There was a problem hiding this comment.
Better to use WARN log level
t/plugin/http-logger2.t
Outdated
| }, | ||
| "uri": "/http-logger/test" | ||
| }]], | ||
| [[{ |
Member
There was a problem hiding this comment.
We should remove the response body check
starsz
approved these changes
Mar 4, 2022
tzssangglass
approved these changes
Mar 4, 2022
spacewander
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
FIX https://the-asf.slack.com/archives/CUC5MN17A/p1646136677114399
Pre-submission checklist: