-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: check plugin init type #6822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tylitianrui The issue link is broken, could you fix it? |
| if plugin.init then | ||
| plugin.init() | ||
| if type(plugin.init) == "function" then | ||
| plugin.init() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check type of plugin.init. customer plugin may define it as other data types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add it in
Line 114 in 761c34a
| if not plugin.priority then |
Frankly, I don't think it makes sense. If |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions. |
|
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Description
plugin.initwhether it isfunctionor not.plugin.initmay be defined as other data typesin custom plugins
Checklist