docs: update "ip-restriction" Plugin docs #6883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Navendu Pottekkat <navendupottekkat@gmail.com>
spacewander
requested changes
Apr 20, 2022
Member
spacewander
left a comment
spacewander
left a comment
There was a problem hiding this comment.
Is it necessary to submit a PR per plugin, while the changes are similar?
Member
Author
|
See discussion in #6877 (comment) |
spacewander
approved these changes
Apr 20, 2022
juzhiyuan
approved these changes
Apr 22, 2022
| - Plugin | ||
| - IP restriction | ||
| - ip-restriction | ||
| description: This document contains information about the Apache APISIX ip-restriction Plugin. |
Member
There was a problem hiding this comment.
We could even improve this section with some semantic keywords here
Member
Author
There was a problem hiding this comment.
Yes. I'm currently keeping it similar. But after we have done some research on what works best, we can definitely change them.
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
May 20, 2022
Signed-off-by: Navendu Pottekkat <navendupottekkat@gmail.com>
5 tasks
spacewander
pushed a commit
that referenced
this pull request
Jun 30, 2022
Signed-off-by: Navendu Pottekkat <navendupottekkat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Navendu Pottekkat navendupottekkat@gmail.com
Description
Updates the documentation of the "ip-restriction" Plugin.
Child PR of #6734