docs: fix bugs in doc of request-validation plugin #6943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smile-luobin <luobin_smile@163.com>
smile-luobin
changed the title
guitu168
reviewed
Apr 27, 2022
Comment on lines
+58
to
+60
| } | ||
| }, | ||
| "rejected_msg": "customize reject message" |
Contributor
There was a problem hiding this comment.
Do you get an error when you create a route with the command before the modification?
Contributor
Author
There was a problem hiding this comment.
Do you get an error when you create a route with the command before the modification?
rejected_msg and rejected_code are properties of schema, not body_schema nor header_schema.
the plugin schema defined in request-validataion plugin is:
local schema = {
type = "object",
properties = {
header_schema = {type = "object"},
body_schema = {type = "object"},
rejected_code = {type = "integer", minimum = 200, maximum = 599, default = 400},
rejected_msg = {type = "string", minLength = 1, maxLength = 256}
},
anyOf = {
{required = {"header_schema"}},
{required = {"body_schema"}}
}
}
spacewander
changed the title
spacewander
approved these changes
Apr 29, 2022
shuaijinchao
approved these changes
May 5, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
May 20, 2022
Signed-off-by: smile-luobin <luobin_smile@163.com>
spacewander
pushed a commit
that referenced
this pull request
Jun 30, 2022
Signed-off-by: smile-luobin <luobin_smile@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: smile-luobin luobin_smile@163.com
Description
fix bugs in doc of request-validation plugin