Skip to content

perf: don't cache all request headers on critical code path #7287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spacewander merged 4 commits into from
Jun 22, 2022
Merged

perf: don't cache all request headers on critical code path #7287

spacewander merged 4 commits into from
Jun 22, 2022

Conversation

@soulbird
Copy link
Contributor

@soulbird soulbird commented Jun 21, 2022 •
edited
Loading

Description

1、core.request.header will get all request headers and cache these, we don't need to do this on critical code paths.
2、We can use api_ctx.var.http_x_forwarded_proto to get only one header we need

Fixes #7258

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@soulbird soulbird marked this pull request as ready for review June 21, 2022 09:59
@spacewander spacewander merged commit f6cdc79 into apache:master Jun 22, 2022
soulbird added a commit to soulbird/apisix that referenced this pull request Jun 24, 2022
@soulbird
perf: don't cache all request headers on critical code path (apache#7287
1f96a96 
)
nic-chen pushed a commit to nic-chen/apisix that referenced this pull request Jun 25, 2022
@soulbird @nic-chen
perf: don't cache all request headers on critical code path (apache#7287
720d4cd 
)
@nic-chen nic-chen mentioned this pull request Jun 25, 2022
Merged
5 tasks
nic-chen pushed a commit to nic-chen/apisix that referenced this pull request Jun 25, 2022
@soulbird @nic-chen
perf: don't cache all request headers on critical code path (apache#7287
9f9005c 
)
@nic-chen nic-chen mentioned this pull request Jun 25, 2022
Closed
5 tasks
spacewander pushed a commit that referenced this pull request Jun 26, 2022
@soulbird
backport: commits to release/2.13 (#7319)
5979559 
* fix: duplicate X-Forwarded-Proto will be sent as string (#7229)

Co-authored-by: soulbird <zhaothree@gmail.com>

* perf: don't cache all request headers on critical code path (#7287)

Co-authored-by: soulbird <zhaothree@gmail.com>
spacewander pushed a commit that referenced this pull request Jun 27, 2022
@nic-chen @soulbird
backport: multi request header X-Forwarded-Proto will be sent to upst…
1266d94 
…ream as string (#7326)

* fix: duplicate X-Forwarded-Proto will be sent as string (#7229)

Co-authored-by: soulbird <zhaothree@gmail.com>

* perf: don't cache all request headers on critical code path (#7287)

Co-authored-by: soulbird <zhaoshir@outlook.com>
Co-authored-by: soulbird <zhaothree@gmail.com>
spacewander pushed a commit that referenced this pull request Jun 30, 2022
@soulbird @spacewander
perf: don't cache all request headers on critical code path (#7287)
0290b30
Liu-Junlin pushed a commit to Liu-Junlin/apisix that referenced this pull request Nov 4, 2022
@soulbird @Liu-Junlin
perf: don't cache all request headers on critical code path (apache#7287
fbf136c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacewander spacewander spacewander approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: read header may cause an abnormally high CPU

3 participants

@soulbird @spacewander @tzssangglass