fix: recovery old pb state after pubsub.new #7728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
previously approved these changes
Aug 18, 2022
monkeyDluffy6017
changed the title
spacewander
reviewed
Aug 18, 2022
| local ok, err = pcall(pubsub_protoc.loadfile, pubsub_protoc, "pubsub.proto") | ||
| if not ok then | ||
| pubsub_protoc:reset() | ||
| return "failed to load pubsub protocol: " .. err |
Member
There was a problem hiding this comment.
Maybe we need to apply the same fix in #7639 (comment) too?
spacewander
approved these changes
Aug 18, 2022
5 tasks
tzssangglass
approved these changes
Aug 18, 2022
Liu-Junlin
pushed a commit
to Liu-Junlin/apisix
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
recovery old pb state after pubsub.new, so that it won't affect other module who use pb state.
Checklist