Skip to content

bugfix(radixtree_host_uri): match priority, host > uri. #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 15, 2019
Merged

bugfix(radixtree_host_uri): match priority, host > uri. #817

merged 5 commits into from
Nov 15, 2019

Conversation

@membphis
Copy link
Member

@membphis membphis commented Nov 7, 2019

Fix #761.

idevz
idevz approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@idevz idevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@membphis membphis mentioned this pull request Nov 7, 2019
Closed
@lilien1010
Copy link
Member

lilien1010 commented Nov 7, 2019

👍

@membphis
Copy link
Member Author

membphis commented Nov 13, 2019

Rebased right now

@lilien1010
Copy link
Member

lilien1010 commented Nov 15, 2019

@membphis when will this PR going to be merged into master？

@membphis
Copy link
Member Author

membphis commented Nov 15, 2019

@membphis when will this PR going to be merged into master?

Have you tested this feature at your ENV?

shuaijinchao
shuaijinchao approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@shuaijinchao shuaijinchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, test case ok.

@membphis membphis merged commit 77ad662 into apache:master Nov 15, 2019
@membphis membphis deleted the bug-router-host-uri branch November 15, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuaijinchao shuaijinchao shuaijinchao approved these changes

+1 more reviewer

@idevz idevz idevz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: 三级泛解析路由规则无法匹配

4 participants

@membphis @lilien1010 @idevz @shuaijinchao