feat(secret): add ci and doc for some auth plugins #8601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
Jan 4, 2023
spacewander
reviewed
Jan 4, 2023
Member
spacewander
left a comment
spacewander
left a comment
There was a problem hiding this comment.
Some auth plugins like ldap-auth and jwt-auth don't exist in this change?
Contributor
Author
I missed it, I'll add it later |
spacewander
reviewed
Jan 6, 2023
spacewander
approved these changes
Jan 6, 2023
tzssangglass
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #8319:
After #8421, all authentication plugins support using APISIX Secret, but only the key-auth plugin adds test case coverage.
Here we have added test cases for basic-auth, hmac-auth, and wolf-rbac plugins using APISIX Secret resources to improve related functions. In addition, the documentation of related plugins is also supplemented.
Checklist