Skip to content

docs: update doc for guide user to config auth etcd #8849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juzhiyuan merged 14 commits into from
Feb 28, 2023
Merged

docs: update doc for guide user to config auth etcd #8849

juzhiyuan merged 14 commits into from
Feb 28, 2023

Conversation

@mscb402
Copy link
Contributor

@mscb402 mscb402 commented Feb 13, 2023

Description

This section of the document "How to configure ETCD auth for APISIX" is indeed missing.

Fixes #8833

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@mscb402 mscb402 changed the title doc: update doc for guide user to config auth etcd docs: update doc for guide user to config auth etcd Feb 13, 2023
@mscb402 mscb402 marked this pull request as ready for review February 13, 2023 10:00
@mscb402
Copy link
Contributor Author

mscb402 commented Feb 14, 2023

@spacewander @tokers please help me review

tokers
tokers reviewed Feb 15, 2023
View reviewed changes
mscb402 and others added 3 commits February 15, 2023 09:48
@mscb402 @tokers
Update docs/en/latest/FAQ.md
a794ba4 
Co-authored-by: Alex Zhang <tokers@apache.org>
@mscb402
Update FAQ.md
5b6da7a
@mscb402
Update FAQ.md
0e4dec2
leslie-tsang
leslie-tsang reviewed Feb 17, 2023
View reviewed changes
mscb402 and others added 3 commits February 17, 2023 17:58
@mscb402 @leslie-tsang
Update docs/zh/latest/FAQ.md
5c965e3 
Co-authored-by: leslie <leslie@apache.org>
@mscb402 @leslie-tsang
Update docs/zh/latest/FAQ.md
bad5f3b 
Co-authored-by: leslie <leslie@apache.org>
@mscb402 @leslie-tsang
Update docs/en/latest/FAQ.md
047ad7c 
Co-authored-by: leslie <leslie@apache.org>
@leslie-tsang leslie-tsang requested a review from tokers February 21, 2023 01:07
@mscb402 mscb402 requested review from leslie-tsang and removed request for tokers February 21, 2023 01:25
leslie-tsang
leslie-tsang reviewed Feb 21, 2023
View reviewed changes
mscb402 and others added 3 commits February 21, 2023 09:39
@mscb402 @leslie-tsang
Update docs/en/latest/FAQ.md
00aae62 
Co-authored-by: leslie <leslie@apache.org>
@mscb402 @leslie-tsang
Update docs/zh/latest/FAQ.md
14a36cc 
Co-authored-by: leslie <leslie@apache.org>
@mscb402 @leslie-tsang
Update docs/en/latest/FAQ.md
1d5bf34 
Co-authored-by: leslie <leslie@apache.org>
@mscb402 mscb402 requested review from leslie-tsang and tokers and removed request for leslie-tsang and tokers February 21, 2023 01:40
tokers
tokers reviewed Feb 22, 2023
View reviewed changes
mscb402 and others added 2 commits February 22, 2023 09:50
@mscb402 @tokers
Update docs/en/latest/FAQ.md
083298f 
Co-authored-by: Alex Zhang <tokers@apache.org>
@mscb402 @tokers
Update docs/zh/latest/FAQ.md
1d73a33 
Co-authored-by: Alex Zhang <tokers@apache.org>
shreemaan-abhishek
shreemaan-abhishek requested changes Feb 22, 2023
View reviewed changes
mscb402 and others added 2 commits February 22, 2023 11:27
@mscb402 @shreemaan-abhishek
Update docs/en/latest/FAQ.md
43dce79 
Co-authored-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
@mscb402
Update FAQ.md
1838112
leslie-tsang
leslie-tsang approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@leslie-tsang leslie-tsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscb402
Copy link
Contributor Author

mscb402 commented Feb 23, 2023

@spacewander

@leslie-tsang leslie-tsang requested review from tokers and removed request for shreemaan-abhishek February 23, 2023 01:37
@juzhiyuan juzhiyuan merged commit 0a9c93e into apache:master Feb 28, 2023
@mscb402 mscb402 deleted the doc/add_faq_for_how_to_auth_etcd branch February 28, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tokers tokers tokers approved these changes

@nic-chen nic-chen nic-chen approved these changes

@leslie-tsang leslie-tsang leslie-tsang approved these changes

@shreemaan-abhishek shreemaan-abhishek Awaiting requested review from shreemaan-abhishek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

if etcd is use auth

6 participants

@mscb402 @tokers @nic-chen @leslie-tsang @shreemaan-abhishek @juzhiyuan