-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: add token support for consul_kv discovery(#9532) #9563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello there, we need a test case for this feature. :) |
|
I'am really waiting for this feature. Edit: Ah, found it. They're here: I have no idea how to execute them right now, but i'll try to provide some tests here. |
|
@leslie-tsang please help to finish this pr |
|
I think i'am almost there. What i've done:
Is this the correct way to go? |
|
@sevensolutions Yeah, it's exactly what you said |
|
@monkeyDluffy6017 thanks. How can i get some logs from APISIX during development? Edit: Found it. |
|
Got it working. I've created #10278 for token support in consul including tests. |
|
Thanks for your contribution! I'will close this pr, it's done by #10278 |
Description
This PR supports the consul_kv service discovery support token function described in #9532.
Checklist
For testing, I don't know how to add test cases yet, but I tested locally that this function can be used normally.