Skip to content

Conversation

@Zebradil
Copy link
Contributor

@Zebradil Zebradil commented May 31, 2023

Description

Change Prometehus queries of the latency graphs to consider selected $route and to use dynamic rate interval ($__rate_interval).

These changes lead to a better user experience with the provided Grafana dashboard. The main focus is to allow users to see latency metrics for a particular route.

The changes don't affect existing users in any way, the default view stays the same. The required version of Grafana stays the same.

These are the altered panels:

image
image
image

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@Zebradil
Copy link
Contributor Author

Zebradil commented Jun 1, 2023

I'm not sure why CI failed. I don't think that it's related to the proposed changes.

@monkeyDluffy6017 monkeyDluffy6017 merged commit 422c8e5 into apache:master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants