Skip to content

Conversation

@Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Jun 6, 2023

Description

Fixes #9598

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Signed-off-by: revolyssup <ashishjaitiwari15112000@gmail.com>
Signed-off-by: revolyssup <ashishjaitiwari15112000@gmail.com>
@Revolyssup
Copy link
Contributor Author

@kayx23 Please review

basic:
enable: true
```
APISIX syncs the configuration passed in debug.yaml on startup and then checks if the file was modified on an interval of 1 second. If the file is changed, then it resyncs the debug configuration so that users don't have to reload for the debug configuration to take effect.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
APISIX syncs the configuration passed in debug.yaml on startup and then checks if the file was modified on an interval of 1 second. If the file is changed, then it resyncs the debug configuration so that users don't have to reload for the debug configuration to take effect.
APISIX loads the configurations of `debug.yaml` on startup and then checks if the file is modified on an interval of 1 second. If the file is changed, APISIX automatically applies the configuration changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Revolyssup could you help confirm in code if:

  • 1 second is the default
  • 1 second could be modified by config under /conf (or is it hardcoded)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kayx23 Here you can see its hardcoded

ngx.timer.every(1, sync_debug_status)

Co-authored-by: Traky Deng <trakydeng@gmail.com>
@Revolyssup
Copy link
Contributor Author

@kayx23 Committed your suggestions.

@kayx23
Copy link
Member

kayx23 commented Jun 6, 2023

@kayx23 Committed your suggestions.

there's a comment too, please check

@Revolyssup
Copy link
Contributor Author

@kayx23 Committed your suggestions.

there's a comment too, please check

@kayx23 replied.

kayx23
kayx23 previously approved these changes Jun 6, 2023
juzhiyuan
juzhiyuan previously approved these changes Jun 6, 2023
Signed-off-by: revolyssup <ashishjaitiwari15112000@gmail.com>
@Revolyssup Revolyssup dismissed stale reviews from juzhiyuan and kayx23 via 5ae591d June 6, 2023 07:29
@monkeyDluffy6017 monkeyDluffy6017 merged commit 71c6048 into apache:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: update Debug Mode doc with reload information

6 participants