Skip to content

docs: Add tutorial on monitoring API health check #9897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
monkeyDluffy6017 merged 8 commits into from
Jul 26, 2023
Merged

docs: Add tutorial on monitoring API health check #9897

monkeyDluffy6017 merged 8 commits into from
Jul 26, 2023

Conversation

@Boburmirzo
Copy link
Contributor

@Boburmirzo Boburmirzo commented Jul 25, 2023 •
edited
Loading

Description

Added a tutorial for Monitor API Health Check with Prometheus

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

juzhiyuan
juzhiyuan previously approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one comment: would better format the JSON format with 2 spaces :)

@Boburmirzo
Copy link
Contributor Author

Boburmirzo commented Jul 25, 2023

I only have one comment: would better format the JSON format with 2 spaces :)
I can format it.

nfrankel
nfrankel requested changes Jul 26, 2023
View reviewed changes
nfrankel
nfrankel requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@nfrankel nfrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed that you properly Grammarly'ed the post but I see it's not the case. Please pass it through Grammarly before the PR

@Boburmirzo
Copy link
Contributor Author

Boburmirzo commented Jul 26, 2023

I assumed that you properly Grammarly'ed the post but I see it's not the case. Please pass it through Grammarly before the PR

Grammarly I used for it.

@Boburmirzo
Copy link
Contributor Author

Boburmirzo commented Jul 26, 2023

image

nfrankel
nfrankel reviewed Jul 26, 2023
View reviewed changes
@monkeyDluffy6017 monkeyDluffy6017 merged commit e910d8c into apache:master Jul 26, 2023
@Boburmirzo Boburmirzo deleted the bobur/monitor-api-healthcheck branch July 26, 2023 08:57
mywildquant pushed a commit to mywildquant/apisix that referenced this pull request Aug 8, 2023
@Boburmirzo @mywildquant
docs: Add tutorial on monitoring API health check (apache#9897)
137c26b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfrankel nfrankel nfrankel approved these changes

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@juzhiyuan juzhiyuan Awaiting requested review from juzhiyuan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Boburmirzo @nfrankel @juzhiyuan @monkeyDluffy6017