Skip to content

Conversation

@shreemaan-abhishek
Copy link
Contributor

Description

The CI uses the nightly version of Openwhisk which might result in inconsistent behavior or build failure altogether.

cc: @kingluo

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

# prepare openwhisk env
docker pull openwhisk/action-nodejs-v14:nightly
docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly
docker pull openwhisk/action-nodejs-v14:7545841
Copy link
Contributor

@monkeyDluffy6017 monkeyDluffy6017 Jul 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version does this id represent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monkeyDluffy6017, it does not represent any version I suppose because, in the openwhisk docker hub, the tags were specified like random numbers (no semantically versioned tags were available). I just found a combination of tags that worked well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very werid

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use docker pull openwhisk/action-nodejs-v14:latest?

kingluo
kingluo previously approved these changes Jul 28, 2023
Copy link
Contributor

@monkeyDluffy6017 monkeyDluffy6017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should find a digital version like this
image

@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Jul 28, 2023
# prepare openwhisk env
docker pull openwhisk/action-nodejs-v14:nightly
docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly
docker pull openwhisk/action-nodejs-v14:7545841
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use docker pull openwhisk/action-nodejs-v14:latest?

docker pull openwhisk/action-nodejs-v14:nightly
docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly
docker pull openwhisk/action-nodejs-v14:7545841
docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:de3e0a8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the version of docker pull openwhisk/standalone ?

@kingluo
Copy link
Contributor

kingluo commented Jul 31, 2023

@moonming latest or nightly can't fix the version and will create conflicts when dependencies change.

docker pull openwhisk/action-nodejs-v14:nightly
docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly
docker exec -i openwhisk waitready
docker exec -i openwhisk bash -c "wsk package create pkg"
docker exec -i openwhisk bash -c "wsk action update /guest/pkg/testpkg <(echo 'function main(args){return {\"hello\": \"world\"}}') --kind nodejs:14"
docker exec -i openwhisk bash -c "wsk action update test <(echo 'function main(args){return {\"hello\": \"test\"}}') --kind nodejs:14"
docker exec -i openwhisk bash -c "wsk action update test-params <(echo 'function main(args){return {\"hello\": args.name || \"test\"}}') --kind nodejs:14"
docker exec -i openwhisk bash -c "wsk action update test-statuscode <(echo 'function main(args){return {\"statusCode\": 407}}') --kind nodejs:14"
docker exec -i openwhisk bash -c "wsk action update test-headers <(echo 'function main(args){return {\"headers\": {\"test\":\"header\"}}}') --kind nodejs:14"
docker exec -i openwhisk bash -c "wsk action update test-body <(echo 'function main(args){return {\"body\": {\"test\":\"body\"}}}') --kind nodejs:14"

2023-07-27T07:35:35.8965822Z ok: updated action testme
2023-07-27T07:35:42.8525542Z     "ready": true
2023-07-27T07:35:43.3148176Z ok: deleted action testme
2023-07-27T07:35:44.0565688Z ok: created package pkg
2023-07-27T07:35:44.7900623Z error: Unable to create action 'pkg/testpkg': The request content was malformed:
2023-07-27T07:35:44.7916960Z The specified runtime 'nodejs:14' is not supported by this platform. Valid values are: 'php:8.1', 'python:3.11', 'ruby:2.5', 'nodejs:18', 'dotnet:3.1', 'blackbox', 'python:3.10', 'rust:1.34', 'swift:5.7', 'java:8', 'sequence', 'dotnet:6.0', 'go:1.20', 'swift:5.3', 'nodejs:20'. (code h8by3ms1qmPROJuVOdStDv4kDyQYohmV)
2023-07-27T07:35:44.7923721Z Run 'wsk --help' for usage.

Therefore, one needs to choose a dedicated version pair that works well.

@moonming
Copy link
Member

@moonming latest or nightly can't fix the version and will create conflicts when dependencies change.

docker pull openwhisk/action-nodejs-v14:nightly
docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly
docker exec -i openwhisk waitready
docker exec -i openwhisk bash -c "wsk package create pkg"
docker exec -i openwhisk bash -c "wsk action update /guest/pkg/testpkg <(echo 'function main(args){return {\"hello\": \"world\"}}') --kind nodejs:14"
docker exec -i openwhisk bash -c "wsk action update test <(echo 'function main(args){return {\"hello\": \"test\"}}') --kind nodejs:14"
docker exec -i openwhisk bash -c "wsk action update test-params <(echo 'function main(args){return {\"hello\": args.name || \"test\"}}') --kind nodejs:14"
docker exec -i openwhisk bash -c "wsk action update test-statuscode <(echo 'function main(args){return {\"statusCode\": 407}}') --kind nodejs:14"
docker exec -i openwhisk bash -c "wsk action update test-headers <(echo 'function main(args){return {\"headers\": {\"test\":\"header\"}}}') --kind nodejs:14"
docker exec -i openwhisk bash -c "wsk action update test-body <(echo 'function main(args){return {\"body\": {\"test\":\"body\"}}}') --kind nodejs:14"

2023-07-27T07:35:35.8965822Z ok: updated action testme
2023-07-27T07:35:42.8525542Z     "ready": true
2023-07-27T07:35:43.3148176Z ok: deleted action testme
2023-07-27T07:35:44.0565688Z ok: created package pkg
2023-07-27T07:35:44.7900623Z error: Unable to create action 'pkg/testpkg': The request content was malformed:
2023-07-27T07:35:44.7916960Z The specified runtime 'nodejs:14' is not supported by this platform. Valid values are: 'php:8.1', 'python:3.11', 'ruby:2.5', 'nodejs:18', 'dotnet:3.1', 'blackbox', 'python:3.10', 'rust:1.34', 'swift:5.7', 'java:8', 'sequence', 'dotnet:6.0', 'go:1.20', 'swift:5.3', 'nodejs:20'. (code h8by3ms1qmPROJuVOdStDv4kDyQYohmV)
2023-07-27T07:35:44.7923721Z Run 'wsk --help' for usage.

Therefore, one needs to choose a dedicated version pair that works well.

Got it

moonming
moonming previously approved these changes Jul 31, 2023
@moonming
Copy link
Member

@monkeyDluffy6017 review again

@monkeyDluffy6017
Copy link
Contributor

@moonming It's not ready now, the image is a temporary version

 docker pull openwhisk/action-nodejs-v14:7545841

I suggest use a digital and formal versison, like
image

@shreemaan-abhishek shreemaan-abhishek dismissed stale reviews from moonming and kingluo via 7eb0e47 July 31, 2023 04:15
@monkeyDluffy6017 monkeyDluffy6017 added approved and removed wait for update wait for the author's response in this issue/PR labels Jul 31, 2023
@monkeyDluffy6017 monkeyDluffy6017 merged commit 521d6c0 into apache:master Jul 31, 2023
kingluo pushed a commit to kingluo/apisix that referenced this pull request Aug 6, 2023
mywildquant pushed a commit to mywildquant/apisix that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants