-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: avoid using nightly version of openwhisk #9919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid using nightly version of openwhisk #9919
Conversation
ci/init-plugin-test-service.sh
Outdated
| # prepare openwhisk env | ||
| docker pull openwhisk/action-nodejs-v14:nightly | ||
| docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly | ||
| docker pull openwhisk/action-nodejs-v14:7545841 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which version does this id represent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@monkeyDluffy6017, it does not represent any version I suppose because, in the openwhisk docker hub, the tags were specified like random numbers (no semantically versioned tags were available). I just found a combination of tags that worked well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very werid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use docker pull openwhisk/action-nodejs-v14:latest?
monkeyDluffy6017
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci/init-plugin-test-service.sh
Outdated
| # prepare openwhisk env | ||
| docker pull openwhisk/action-nodejs-v14:nightly | ||
| docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly | ||
| docker pull openwhisk/action-nodejs-v14:7545841 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use docker pull openwhisk/action-nodejs-v14:latest?
ci/init-plugin-test-service.sh
Outdated
| docker pull openwhisk/action-nodejs-v14:nightly | ||
| docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:nightly | ||
| docker pull openwhisk/action-nodejs-v14:7545841 | ||
| docker run --rm -d --name openwhisk -p 3233:3233 -p 3232:3232 -v /var/run/docker.sock:/var/run/docker.sock openwhisk/standalone:de3e0a8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the version of docker pull openwhisk/standalone ?
|
@moonming latest or nightly can't fix the version and will create conflicts when dependencies change. apisix/ci/init-plugin-test-service.sh Lines 25 to 35 in cea8f10
Therefore, one needs to choose a dedicated version pair that works well. |
Got it |
|
@monkeyDluffy6017 review again |
|
@moonming It's not ready now, the image is a temporary version |
7eb0e47


Description
The CI uses the nightly version of Openwhisk which might result in inconsistent behavior or build failure altogether.
cc: @kingluo
Fixes # (issue)
Checklist