General cleanup#96
Conversation
| <dependency> | ||
| <groupId>jakarta.xml.bind</groupId> | ||
| <artifactId>jakarta.xml.bind-api</artifactId> | ||
| <version>4.0.5</version> |
There was a problem hiding this comment.
when refactoring then you can consider creating properties
There was a problem hiding this comment.
Are you referring to the two dependencies with version 4.0.5? They are from different groups so I'm not sure they are supposed to always have an identical version. If there are other sibling dependencies that should share a version that were missed let me know and I'll extract a property.
There was a problem hiding this comment.
It's not about this version exactly - it's more a common practice in maven project to keep deps version in properties e.g. https://github.com/apache/aries/blob/trunk/parent/pom.xml#L183
There was a problem hiding this comment.
oh, I wasn't aware of the practive to do it for every single dependency... that would add lots of lines and lots of jumping around to see the versions. I know it's used often when there are multiple sibling dependencies that all have to be updated in lockstep (like different modules from one project release), then the property makes sure none of them will be forgotten and makes the upgrades easier.
However if it is the common practice in aries to extract all versions of all deps into properties let me know and I'll do it.
There was a problem hiding this comment.
Aries is a separate repo, we don't need to follow the same approach here (but it would be good) - nevertheless I approved the PR long time ago, so feel free to merge
amichair
force-pushed
the
general-cleanup
branch
from
7cec0f3 to
4974ee6
Compare
2 participants
No description provided.