[DISCUSS] FlightSQL tracing: expected relationship between Open, statement/query spans, and connection-level correlation #4572
binarycat-dremio
started this conversation in
General
Replies: 1 comment
I don't know about grouping them all under the same span/trace, but if we don't group them under the same span/trace then we should at least connect with them with some sort of ID metadata.
I think it might make sense for everything under a given statement being one logical trace, most definitely.
My personal preference would be a stable connection_id attribute on the statement/cursor spans rather than parent-child trace linkage since it's common that a connection might be used for multiple queries/statements. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Hello colleagues,
I'd like to clarify the intended tracing model for ADBC FlightSQL.
In a typical DB-API flow like:
there seem to be a few possible interpretations of how tracing should behave, and I'm not sure which one is the expected design.
Questions:
FlightSQLDatabase.Openspan/trace?execute(...)operation start its own logical trace?connection_idattribute on statement/cursor spans rather than parent-child trace linkage?From an observability perspective, I can see two reasonable models:
Openis the parent context, and laterPrepare/ExecuteQueryspans for that connection are grouped beneath it.connection_id.I'm mainly trying to understand the intended behavior before proposing any broader change.
Related:
cc: @lidavidm @xborder @zeroshade @Mandukhai-Alimaa @amoeba
The current state with splitted traces.
The possible implementation with grouped query spans under Open entry.
All reactions