Skip to content

chore(r): Synchronize vendoring scripts with latest changes#1809

Merged
paleolimbot merged 4 commits intoapache:mainfrom
paleolimbot:r-sync-ignores
May 4, 2024
Merged

chore(r): Synchronize vendoring scripts with latest changes#1809
paleolimbot merged 4 commits intoapache:mainfrom
paleolimbot:r-sync-ignores

Conversation

@paleolimbot
Copy link
Member

The updates to the Postgres and SQLite drivers were mostly good (thank you for doing them!)...these changes just iron out a few kinks:

  • A few files weren't being ignored when building the driver during development
  • The SQLite driver was still trying to copy sqlite3 from tools/. This existed on my computer and so it worked while packaging during release, but the tarball was over the 5 MB limit (CRAN pushed it through anyway) and we were both linking and vendoring sqlite3 in every installation. Because of this one we have a few notes on the package check page (but no message from CRAN yet): https://cran.r-project.org/web/checks/check_results_adbcsqlite.html

@github-actions github-actions bot added this to the ADBC Libraries 1.0.0 milestone May 3, 2024
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry about the missed changes. Thanks for fixing it!

@paleolimbot
Copy link
Member Author

I will someday find a better system for making it less painful to refactor the upstream driver!

@paleolimbot paleolimbot merged commit d426d80 into apache:main May 4, 2024
@paleolimbot paleolimbot deleted the r-sync-ignores branch July 9, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants