chore(dev/release): add binary verification #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I still need to test this on macOS |
Member
Author
|
Should work fine, but I have only an M1 mac, so time to figure out the M1 wheels. |
kou
reviewed
Dec 5, 2022
lidavidm
force-pushed
the
binary-verification
branch
from
3503370 to
c29befb
Compare
Member
Author
|
Alright! Now that the wheels are fixed, binary verification finally passes on macOS. |
lidavidm
force-pushed
the
binary-verification
branch
from
c793f9d to
5ca7ef3
Compare
kou
approved these changes
Dec 7, 2022
Comment on lines
650
to
655
| if [ "$(uname)" == "Darwin" ]; then | ||
| local filter_regex=.*macosx.* | ||
| else | ||
| local filter_regex=.*manylinux.* | ||
| fi | ||
|
|
Member
There was a problem hiding this comment.
It seems that we can remove them too.
.github/workflows/verify.yml
Outdated
| TEST_BINARIES: "1" | ||
| USE_CONDA: "1" | ||
| run: | | ||
| sudo -E ./dev/release/verify-release-candidate.sh ${{ inputs.version }} ${{ inputs.rc }} |
Member
Author
There was a problem hiding this comment.
Ah, that should work. Updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.