ci(javascript): fix flaky msvc test#4127
Merged
zeroshade merged 1 commit intoapache:mainfrom Mar 20, 2026
Merged
Conversation
zeroshade
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the flaky msvc JavaScript tests.
Disables static SQLite build as it's not necessary for the test suite, and sets
--config RelWithDebInfoto ensure we build with the correct config on windows.Test Plan
Ran on my fork a few times and saw no more failures
https://github.com/kentkwu/arrow-adbc/actions/workflows/javascript.yml?query=event%3Aworkflow_dispatch+branch%3Agh-4124
closes #4124