Skip to content

fix(csharp/src/Drivers): Make AdbcCommandTimeoutProperty to optional#4197

Merged
CurtHagenlocher merged 1 commit intoapache:mainfrom
dandandanliu915:dev/liudan7/fixTimeout
Apr 8, 2026
Merged

fix(csharp/src/Drivers): Make AdbcCommandTimeoutProperty to optional#4197
CurtHagenlocher merged 1 commit intoapache:mainfrom
dandandanliu915:dev/liudan7/fixTimeout

Conversation

@dandandanliu915
Copy link
Copy Markdown
Contributor

@dandandanliu915 dandandanliu915 commented Apr 8, 2026

Previously, setting CommandTimeout required AdbcCommandTimeoutProperty to be set first, throwing InvalidOperationException if it was not, specifically in Snowflake's case.
Now, AdbcCommandTimeoutProperty is nullable and CommandTimeout stores the value locally when no driver property is configured, only propagating to the driver via SetOption when the property is set.
Fixed previous PR: #2312

…\nPreviously, setting CommandTimeout required AdbcCommandTimeoutProperty to be\nset first, throwing InvalidOperationException if it was not. Now,\nAdbcCommandTimeoutProperty is nullable and CommandTimeout stores the value\nlocally when no driver property is configured, only propagating to the driver\nvia SetOption when the property is set."
@dandandanliu915 dandandanliu915 changed the title Make AdbcCommandTimeoutProperty optional for setting CommandTimeout\n… Make AdbcCommandTimeoutProperty optional for setting CommandTimeout Apr 8, 2026
@dandandanliu915 dandandanliu915 changed the title Make AdbcCommandTimeoutProperty optional for setting CommandTimeout fix(csharp/src/Drivers/Apache): Make AdbcCommandTimeoutProperty to optional Apr 8, 2026
@dandandanliu915 dandandanliu915 changed the title fix(csharp/src/Drivers/Apache): Make AdbcCommandTimeoutProperty to optional fix(csharp/src/Drivers): Make AdbcCommandTimeoutProperty to optional Apr 8, 2026
Copy link
Copy Markdown
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CurtHagenlocher CurtHagenlocher merged commit 6444fd7 into apache:main Apr 8, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants