Feature return task error on panic #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nl5887
force-pushed
the
feature-return-task-error-on-panic
branch
from
1031daf to
c33d667
Compare
thinkharderdev
approved these changes
Jun 13, 2022
Contributor
thinkharderdev
left a comment
thinkharderdev
left a comment
There was a problem hiding this comment.
Looks like a good improvement to me!
Member
|
@nl5887 Do you have examples of panics that this fixes? Can we fix the root cause by using |
Contributor
Author
One of the cases this occurs, is when schemas aren't compatible. (eg in situations of an expect()). With this commit, it at least will return that task failed, instead of keeping it open. Completely agree with that the root causes should be fixed and using Result, but this fix is related to the edge cases. |
andygrove
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in case of a panic in the task executor, no task status will be returned. This commit will catch panics and return the error as task result.