Add benchmark derived from TPC-H #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@kylebrooks-8451 fyi |
andygrove
commented
Apr 28, 2023
dev/release/rat_exclude_files.txt
Outdated
| */.git | ||
| .github/* | ||
| .github/* | ||
| benchmarks/tpch/queries/q*.sql |
Member
Author
There was a problem hiding this comment.
The queries are copyright TPC so we can't claim ASF copyright
jdye64
reviewed
May 1, 2023
Contributor
jdye64
left a comment
jdye64
left a comment
There was a problem hiding this comment.
LGTM. Had a single question/comment about if a disclaimer should have been included in the DDL file. I don't know the answer so approving and letting you use your judgement there.
benchmarks/tpch/create_tables.sql
Outdated
| @@ -0,0 +1,133 @@ | |||
| -- Licensed to the Apache Software Foundation (ASF) under one | |||
Contributor
There was a problem hiding this comment.
Should this also contain the disclaimer about being derived from TPC-H since it is performing DDL? Don't know the answer there?
Member
Author
There was a problem hiding this comment.
Good point. I will go ahead and add this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Make it easier to run benchmarks so we can track performance between releases and catch regressions earlier.
I had to add a workaround for apache/datafusion#6147 by renaming the generated
.tblfiles to.csvfiles.What changes are included in this PR?
Are there any user-facing changes?