Add db-benchmark #365
Merged
Add db-benchmark #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrPowers fyi |
r4ntix
reviewed
May 3, 2023
| && cp ../arrow-datafusion/benchmarks/db-benchmark/join-datafusion.py db-benchmark/datafusion \ | ||
| && cp ../arrow-datafusion/benchmarks/db-benchmark/run-bench.sh db-benchmark/ \ | ||
| && chmod +x db-benchmark/run-bench.sh | ||
|
|
There was a problem hiding this comment.
Both the documentation and the arrow-datafusion related paths in the docker file need to be upgraded to arrow-datafusion-python
There was a problem hiding this comment.
Yes, we also need to stop having it clone the repo when building the docker image. I've filed #368 for the follow on work once this is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Move db-benchmark from arrow-datafusion repo to arrow-datafusion-python repo. This makes more sense because these are Python benchmarks.
There is a corresponding PR to remove this benchmark from the
arrow-datafusionrepo:apache/datafusion#6204
What changes are included in this PR?
Move files from arrow-datafusion repo
Note that additional work is required to get these working again, such as updating some of the paths in the Dockerfile.
Are there any user-facing changes?
No