nested query fix #2402
Merged
nested query fix #2402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
reviewed
May 2, 2022
andygrove
approved these changes
May 2, 2022
andygrove
reviewed
May 2, 2022
| ) foo"; | ||
| let actual = execute_to_batches(&ctx, sql).await; | ||
| // the purpose of this test is just to make sure the query produces a valid plan | ||
| let expected = vec!["+-----+", "| cnt |", "+-----+", "| 0 |", "+-----+"]; |
Member
There was a problem hiding this comment.
Could you disable rustfmt for this line and format it so that it is easier to read, as shown in #2413
Member
There was a problem hiding this comment.
I'm going to go ahead and merge this. Perhaps we can improve the test formatting as a separate PR.
gandronchik
pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Sep 8, 2022
gandronchik
added a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2381.
Rationale for this change
What changes are included in this PR?
Fix bug with nested queries panicked because of NotImplemented
Are there any user-facing changes?