Skip to content

Conversation

@jdye64
Copy link
Contributor

@jdye64 jdye64 commented Jan 13, 2023

…ytes without reading/writing to file

Which issue does this PR close?

Closes #4891

@andygrove
Copy link
Member

The substrait crate isn't fully integrated yet (see #4880 - I am about to create a PR for this), so you'll need to run cargo test from the datafusion/substrait directory for now.

@alamb alamb added the substrait Changes to the substrait crate label Jan 15, 2023
@jdye64
Copy link
Contributor Author

jdye64 commented Jan 18, 2023

I'm going to make a PR for add DataFusionError::substrait that I would like to be merged before this. After that is merged I will update this PR accordingly. I'm going to convert this PR to draft until then.

@jdye64 jdye64 marked this pull request as draft January 18, 2023 14:08
@jdye64
Copy link
Contributor Author

jdye64 commented Jan 18, 2023

PR for DataFusionError::Substrait variant for reference.

@jdye64 jdye64 marked this pull request as ready for review January 18, 2023 18:30
@jdye64
Copy link
Contributor Author

jdye64 commented Jan 18, 2023

@andygrove does this look ok to you after the changes to DataFusionError::Substrait?

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jdye64!

@andygrove andygrove merged commit 6dce728 into apache:master Jan 19, 2023
@ursabot
Copy link

ursabot commented Jan 19, 2023

Benchmark runs are scheduled for baseline = 5025aa5 and contender = 6dce728. 6dce728 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serialize/Deserialize substrait protobuf bytes without reading/writing to file

4 participants