-
Notifications
You must be signed in to change notification settings - Fork 1.9k
refactor and add simple function to deserialize and serialize proto b… #4892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ytes without reading/writing to file
|
The substrait crate isn't fully integrated yet (see #4880 - I am about to create a PR for this), so you'll need to run |
…ze_bytes to return a Result
|
I'm going to make a PR for add DataFusionError::substrait that I would like to be merged before this. After that is merged I will update this PR accordingly. I'm going to convert this PR to draft until then. |
|
PR for DataFusionError::Substrait variant for reference. |
|
@andygrove does this look ok to you after the changes to |
andygrove
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @jdye64!
|
Benchmark runs are scheduled for baseline = 5025aa5 and contender = 6dce728. 6dce728 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…ytes without reading/writing to file
Which issue does this PR close?
Closes #4891