Rename Variant assemblies to Scalars#323
Merged
CurtHagenlocher merged 8 commits intoapache:mainfrom Apr 22, 2026
Merged
Conversation
Rename assembly, project, namespace, and test project: - src/Apache.Arrow.Variant -> src/Apache.Arrow.Scalars - test/Apache.Arrow.Variant.Tests -> test/Apache.Arrow.Scalars.Tests - Update all namespace references across the solution Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move all Variant*.cs files into a Variant/ subdirectory within src/Apache.Arrow.Scalars and update the namespace from Apache.Arrow.Scalars to Apache.Arrow.Scalars.Variant. Update using directives in all consumers: Operations, Tests, and Benchmarks projects. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR renames the former Apache.Arrow.Variant library/test assemblies to Apache.Arrow.Scalars and updates namespaces/usings and project references so Variant-related APIs live under Apache.Arrow.Scalars.Variant.
Changes:
- Introduces the new
Apache.Arrow.Scalarsproject and moves Variant types intoApache.Arrow.Scalars.Variant. - Updates Operations JSON code and tests to reference the new
Apache.Arrow.Scalars.Variantnamespace/project. - Renames test/benchmark namespaces and solution/slnf/release-script references from Variant to Scalars.
Reviewed changes
Copilot reviewed 42 out of 43 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Apache.Arrow.Variant.Benchmarks/StructVariantValue.cs | Updates namespace/imports to Scalars/Variant. |
| test/Apache.Arrow.Variant.Benchmarks/Program.cs | Updates namespace/imports to Scalars/Variant. |
| test/Apache.Arrow.Variant.Benchmarks/MixedWorkloadBenchmarks.cs | Updates namespace/imports to Scalars/Variant. |
| test/Apache.Arrow.Variant.Benchmarks/EqualityBenchmarks.cs | Updates namespace/imports to Scalars/Variant. |
| test/Apache.Arrow.Variant.Benchmarks/EncodingBenchmarks.cs | Updates namespace/imports to Scalars/Variant. |
| test/Apache.Arrow.Variant.Benchmarks/CreationBenchmarks.cs | Updates namespace/imports to Scalars/Variant. |
| test/Apache.Arrow.Variant.Benchmarks/ArrayBenchmarks.cs | Updates namespace/imports to Scalars/Variant. |
| test/Apache.Arrow.Variant.Benchmarks/Apache.Arrow.Variant.Benchmarks.csproj | Retargets project reference to Apache.Arrow.Scalars. |
| test/Apache.Arrow.Variant.Benchmarks/AccessBenchmarks.cs | Updates namespace/imports to Scalars/Variant. |
| test/Apache.Arrow.Scalars.Tests/VariantValueTests.cs | Updates namespace/imports to Apache.Arrow.Scalars.Variant. |
| test/Apache.Arrow.Scalars.Tests/VariantSqlDecimalTests.cs | Updates namespace/imports to Apache.Arrow.Scalars.Variant. |
| test/Apache.Arrow.Scalars.Tests/VariantRoundTripTests.cs | Updates namespace/imports to Apache.Arrow.Scalars.Variant. |
| test/Apache.Arrow.Scalars.Tests/VariantReaderPrimitiveTests.cs | Updates namespace/imports to Apache.Arrow.Scalars.Variant. |
| test/Apache.Arrow.Scalars.Tests/VariantReaderObjectTests.cs | Updates namespace/imports to Apache.Arrow.Scalars.Variant. |
| test/Apache.Arrow.Scalars.Tests/VariantReaderArrayTests.cs | Updates namespace/imports to Apache.Arrow.Scalars.Variant. |
| test/Apache.Arrow.Scalars.Tests/VariantMetadataTests.cs | Updates namespace/imports to Apache.Arrow.Scalars.Variant. |
| test/Apache.Arrow.Scalars.Tests/VariantEncodingHelperTests.cs | Updates namespace/imports to Apache.Arrow.Scalars.Variant. |
| test/Apache.Arrow.Scalars.Tests/VariantBuilderTests.cs | Updates namespace/imports to Apache.Arrow.Scalars.Variant. |
| test/Apache.Arrow.Scalars.Tests/TestVectors.cs | Updates namespace/imports to Apache.Arrow.Scalars.Variant. |
| test/Apache.Arrow.Scalars.Tests/ParquetTestingVectorTests.cs | Updates namespace/imports to Apache.Arrow.Scalars.Variant. |
| test/Apache.Arrow.Scalars.Tests/Apache.Arrow.Scalars.Tests.csproj | Retargets project reference to Apache.Arrow.Scalars. |
| test/Apache.Arrow.Operations.Tests/Json/VariantJsonTests.cs | Switches using from Variant to Scalars.Variant. |
| test/Apache.Arrow.Operations.Tests/Json/VariantDecimalJsonTests.cs | Switches using from Variant to Scalars.Variant. |
| src/Apache.Arrow.Scalars/Variant/VariantValueWriter.cs | Moves type into Apache.Arrow.Scalars.Variant namespace. |
| src/Apache.Arrow.Scalars/Variant/VariantValue.cs | Moves type into Apache.Arrow.Scalars.Variant namespace. |
| src/Apache.Arrow.Scalars/Variant/VariantReader.cs | Moves type into Apache.Arrow.Scalars.Variant namespace. |
| src/Apache.Arrow.Scalars/Variant/VariantPrimitiveType.cs | Moves type into Apache.Arrow.Scalars.Variant namespace. |
| src/Apache.Arrow.Scalars/Variant/VariantObjectReader.cs | Moves type into Apache.Arrow.Scalars.Variant namespace. |
| src/Apache.Arrow.Scalars/Variant/VariantMetadataBuilder.cs | Moves type into Apache.Arrow.Scalars.Variant namespace. |
| src/Apache.Arrow.Scalars/Variant/VariantMetadata.cs | Moves type into Apache.Arrow.Scalars.Variant namespace. |
| src/Apache.Arrow.Scalars/Variant/VariantEncodingHelper.cs | Moves type into Apache.Arrow.Scalars.Variant namespace. |
| src/Apache.Arrow.Scalars/Variant/VariantBuilder.cs | Moves type into Apache.Arrow.Scalars.Variant namespace. |
| src/Apache.Arrow.Scalars/Variant/VariantBasicType.cs | Moves type into Apache.Arrow.Scalars.Variant namespace. |
| src/Apache.Arrow.Scalars/Variant/VariantArrayReader.cs | Moves type into Apache.Arrow.Scalars.Variant namespace. |
| src/Apache.Arrow.Scalars/Properties/AssemblyInfo.cs | Updates InternalsVisibleTo to Apache.Arrow.Scalars.Tests. |
| src/Apache.Arrow.Scalars/Apache.Arrow.Scalars.csproj | Adds new Scalars project definition. |
| src/Apache.Arrow.Operations/Json/VariantJsonWriter.cs | Switches using from Variant to Scalars.Variant. |
| src/Apache.Arrow.Operations/Json/VariantJsonReader.cs | Switches using from Variant to Scalars.Variant. |
| src/Apache.Arrow.Operations/Json/VariantJsonConverter.cs | Switches using from Variant to Scalars.Variant. |
| src/Apache.Arrow.Operations/Apache.Arrow.Operations.csproj | Updates project reference to Apache.Arrow.Scalars. |
| dev/release/verify_rc.sh | Updates package verification references to Scalars packages/tests. |
| Apache.Arrow.sln | Renames solution project entries from Variant to Scalars. |
| Apache.Arrow.Tests.slnf | Updates solution filter to include Apache.Arrow.Scalars.Tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adamreeve
approved these changes
Apr 22, 2026
Contributor
adamreeve
left a comment
adamreeve
left a comment
There was a problem hiding this comment.
Looks good to me thanks Curt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Apache.Arrow.Variantproject and assembly toApache.Arrow.ScalarsApache.Arrow.Variant.Testsproject and assembly toApache.Arrow.Scalars.TestsApache.Arrow.Scalars.Variantnamespace