Skip to content

Fix integration tests by modifying CompareVariadicArrays#360

Merged
CurtHagenlocher merged 3 commits into
apache:mainfrom
CurtHagenlocher:FixTest
May 18, 2026
Merged

Fix integration tests by modifying CompareVariadicArrays#360
CurtHagenlocher merged 3 commits into
apache:mainfrom
CurtHagenlocher:FixTest

Conversation

@CurtHagenlocher
Copy link
Copy Markdown
Contributor

@CurtHagenlocher CurtHagenlocher commented May 18, 2026

What's Changed

Fix integration tests by modifying CompareVariadicArrays so that it only does a direct buffer comparison when _strictCompare is enabled.

Fixes #359

@adamreeve
Copy link
Copy Markdown
Contributor

Rather than remove this completely, we might want to put it behind an if (_strictCompare) check? It looks like _strictCompare is set to false for the integration tests:

ArrowReaderVerifier.CompareBatches(jsonFileRecordBatch, arrowFileRecordBatch, strictCompare: false);

@CurtHagenlocher
Copy link
Copy Markdown
Contributor Author

Rather than remove this completely, we might want to put it behind an if (_strictCompare) check? It looks like _strictCompare is set to false for the integration tests:

That's a good idea; I'd forgotten about that flag but I think it's pretty much meant for this exact scenario. I'm just waiting to validate that the tests pass with this change since we're already twenty minutes in ...

@CurtHagenlocher CurtHagenlocher changed the title Disable bad test Fix integration tests by modifying CompareVariadicArrays May 18, 2026
@CurtHagenlocher CurtHagenlocher merged commit cc3d329 into apache:main May 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration tests failing with Rust producing and .NET consuming binary views

2 participants