Skip to content

Add support for prepared statement SELECT without parameters #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2023
Merged

Add support for prepared statement SELECT without parameters #179

merged 1 commit into from
Dec 9, 2023

Conversation

@kou
Copy link
Member

@kou kou commented Dec 9, 2023

Closes GH-178

@kou kou mentioned this pull request Dec 9, 2023
Closed
vogelsgesang
vogelsgesang approved these changes Dec 9, 2023
View reviewed changes
Copy link

@vogelsgesang vogelsgesang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that the original query

       cur.execute("SELECT 42;")

works now. That being said, I have little experience with coding against Postgres or ArrowFlight, so take my approval with a grain of salt

@kou
Copy link
Member Author

kou commented Dec 9, 2023

Thanks for your review!
I'll merge this.

@kou kou merged commit 8fabbb9 into apache:main Dec 9, 2023
@kou kou deleted the select-prepare-no-bind branch December 9, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vogelsgesang vogelsgesang vogelsgesang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Querying through Python ADBC hangs forever

2 participants

@kou @vogelsgesang