fix: add nullability to struct type String()#700
Merged
zeroshade merged 1 commit intoapache:mainfrom Mar 10, 2026
Merged
Conversation
zeroshade
approved these changes
Mar 10, 2026
Member
zeroshade
left a comment
There was a problem hiding this comment.
Thanks for this! It looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We frequently run into panic:
panic: arrow/array: column "colName" type mismatch, got=.., want=...
The got and want will be exactly the same schema, the only difference is in the nullability of certain struct fields. The only way to figure out which fields are the problem is to go through the debugger.
The nullability is rendered for other types like map and list, so it seems like it should be there for struct fields as well.
What changes are included in this PR?
Are these changes tested?
ran make test, didn't have the parquet test files, so didn't run those.
Are there any user-facing changes?
Yes, the String() representation for data types is user facing.